Skip to content

Include marker and unknown teams with a website section #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 17, 2025

Before, they were not shown on the website, even though they had a website section in team. The current main motivation for this is to include GSoC mentors and contributors on the website, under the launching pad.

I think that the only other team other than GSoC mentors that is a marker team and has a website section now is https://github.com/rust-lang/team/blob/c4c9de724db63ea7479da976f3ebbcb9b34970ed/teams/alumni.toml. But since they don't have a parent team, and are not a top level team, I suppose that they won't be shown on the website?

@Kobzol Kobzol requested a review from a team as a code owner May 17, 2025 09:07
Before, they were not shown on the website, even though they had a website section in `team`.
@Kobzol Kobzol force-pushed the include-other-teams branch from 77fecc8 to 246b098 Compare May 17, 2025 09:09
@senekor senekor merged commit 1096390 into rust-lang:master May 17, 2025
1 check passed
@senekor
Copy link
Contributor

senekor commented May 17, 2025

The gap between the mentors team and the ones above is bigger, because they are in different sections. I guess it's not a big deal?

image

image

@Kobzol
Copy link
Contributor Author

Kobzol commented May 17, 2025

Well, it's kind of intended, because they are indeed different sections, it's just that it's not really shown on the website and they have the same color. There should be the same gap between WGs and project groups, so I think that it's fine.

@Kobzol Kobzol deleted the include-other-teams branch May 17, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants