-
Notifications
You must be signed in to change notification settings - Fork 112
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ndk: Add missing brackets to linkes to functions in doc-comments in n…
…dk::midi
- Loading branch information
Showing
2 changed files
with
8 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,11 +4,11 @@ | |
//! the Java VM when being dropped, which is required by [`AMidiDevice_release`]. All other types | ||
//! of this module holds an [`Arc`] of `SafeMidiDeviceBox`. | ||
//! | ||
//! Note that all other functions except for [`AMidiDevice_fromJava`] and [`AMidiDevice_release`] | ||
//! are safe to be called in any thread without the calling thread attached to the Java VM. | ||
//! Note that all other functions except for [`ffi::AMidiDevice_fromJava()`] and | ||
//! [`ffi::AMidiDevice_release()`] are safe to be called in any thread without the calling thread | ||
//! attached to the Java VM. | ||
//! | ||
//! [`AMidiDevice`]: https://developer.android.com/ndk/reference/group/midi#amididevice | ||
//! [`AMidiDevice_release`]: https://developer.android.com/ndk/reference/group/midi#amididevice_release | ||
//! [`AMidiInputPort`]: https://developer.android.com/ndk/reference/group/midi#amidiinputport | ||
//! [`AMidiOutputPort`]: https://developer.android.com/ndk/reference/group/midi#amidioutputport | ||
|
||
|
@@ -27,7 +27,7 @@ use super::*; | |
/// [`MidiDevice`] is not dropped while the safe wrappers are alive. | ||
/// | ||
/// [`SafeMidiDeviceBox`] also holds a pointer to the current Java VM to attach the calling thread | ||
/// of [`Drop::drop`] to the VM, which is required by [`ffi::AMidiDevice_release`]. | ||
/// of [`Drop::drop`] to the VM, which is required by [`ffi::AMidiDevice_release()`]. | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
paxbun
Author
Contributor
|
||
struct SafeMidiDeviceBox { | ||
midi_device: ManuallyDrop<MidiDevice>, | ||
java_vm: NonNull<jni_sys::JavaVM>, | ||
|
Drop::drop()
? Or justdrop()
or justDrop
?