Support building APKs from Android host #138
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Sep 14, 2023
xbuild/src/download.rs
Outdated
Comment on lines
145
to
150
| if Platform::host()? != Platform::Android { | ||
| self.rustup_target("aarch64-linux-android") | ||
| .context("rustup_target")?; | ||
| } else { | ||
| info!("Skipping `rustup` for Android target"); | ||
| } |
There was a problem hiding this comment.
termux doesn't have rustup, but I'm not sure if we should generally skip this step if platform() == Platform::host()?, same for the architecture. We still want to prefetch the NDK and JAR file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.