Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: Auto include locals and skip non-dirs and excluded in workspace member search #184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SamRodri
Copy link

@SamRodri SamRodri commented Aug 3, 2024

Workspaces with glob member paths can match files too, cargo metadata ignores file matches, this behavior is now replicated in Manifest::members, fixes #183.

Implements exclude globs and auto includes local path dependencies (see docs).

@MarijnS95 MarijnS95 changed the title Fix workspace members manifest search cargo: Skip non-directories in workspace member search Aug 3, 2024
@SamRodri SamRodri changed the title cargo: Skip non-directories in workspace member search cargo: Skip non-dirs and excluded in workspace member search Aug 3, 2024
@SamRodri SamRodri changed the title cargo: Skip non-dirs and excluded in workspace member search cargo: Auto include locals and skip non-dirs and excluded in workspace member search Aug 3, 2024
@SamRodri
Copy link
Author

SamRodri commented Aug 3, 2024

I also implemented auto include from target dependencies in the target branch, tell me if you want that commit in this pull request. It would match the cargo metadata behavior, but it maybe implies support for cfg dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Failed to load manifest for workspace member workspace/crates/README.md
1 participant