Skip to content

Conversation

redweasel
Copy link

Going through the tests I found a couple places where the conj() test was misspelled. There was also a problem with the acosh test, where the zero sign of the imaginary part was not correctly tested and not correctly handled in the function. The fix was to only divide by the real 2 instead of the complex 2.

@redweasel
Copy link
Author

This also fixes #113 so that test can be merged afterwards as well.

@youknowone
Copy link

@redweasel could you cherry-pick the commit from #113 to ensure it is fixed?

@redweasel
Copy link
Author

I retract my statement. Actually both cases had not been fixed. Now (with my last commit) the atanh case is fixed, but the atan case remains unfixed. The correct fix would be to add a function to multiply by i, as the multiplication and division by i deletes zero signs. Since that changes the API and I didn't want to write a private function for that, I have not included that fix here. Feel free to fix it in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants