Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acpi: add support for SRAT #241

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jellllly420
Copy link
Contributor

@jellllly420 jellllly420 commented Feb 3, 2025

This PR adds support for System Resource Affinity Table (SRAT) and may fix #46. I have not tested this patch for correctness so I'll mark it as draft for now.

I wrote this patch because we want to acquire the affinity (or topology) information of hardwares to support NUMA platform in our project. Another follow-up PR for System Locality Information Table (SLIT) is on its way.

@jellllly420 jellllly420 force-pushed the feat/srat branch 3 times, most recently from 5c8a0e7 to fb87df1 Compare February 10, 2025 18:49
@jellllly420 jellllly420 marked this pull request as ready for review February 10, 2025 18:53
@jellllly420
Copy link
Contributor Author

I've tested this patch against our project and it seems OK. Now ready for review.

@jellllly420
Copy link
Contributor Author

jellllly420 commented Feb 11, 2025

@azongchang I noticed you reviewed this PR while it was still draft. So maybe you are interested in the change? It would be great if you could test it against your need or review it again since it's now marked ready. Thank you.

@azongchang
Copy link

azongchang commented Feb 11, 2025

@azongchang I noticed you reviewed this PR while it was still draft. So maybe you are interested in the change? It would be great if you could test it against your need or review it again since it's now marked ready. Thank you.

@jellllly420 Thanks for reaching out! I did review the PR earlier because I currently focused on preparing NUMA architecture for a Rust OS. However, I’m still in the early stages of that work, so I won’t be able to test this change comprehensively or provide a detailed review in the near future.

@jellllly420
Copy link
Contributor Author

Friendly ping @IsaacWoods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse the SRAT
2 participants