Skip to content

aml: support multiple interrupt numbers#52

Open
lgfa29 wants to merge 1 commit into
rust-vmm:mainfrom
oxidecomputer:aml-multiple-interrupt
Open

aml: support multiple interrupt numbers#52
lgfa29 wants to merge 1 commit into
rust-vmm:mainfrom
oxidecomputer:aml-multiple-interrupt

Conversation

@lgfa29
Copy link
Copy Markdown
Contributor

@lgfa29 lgfa29 commented May 1, 2026

Summary of the PR

The ACPI spec allows multiple interrupt numbers to be specified in the extended interrupt descriptor.

This is breaking change, so it probably needs further consideration before merge. A few options to avoid breaking the API include:

  1. create a separate struct to generate Interrupts with multiple numbers.
  2. keep the constructor the same, but add a new method to include additional numbers.

Let me know how what would be preference and I can adjust the PR.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

Expand `Interrupt` to support multiple interrupt numbers.

Signed-off-by: Luiz Aoqui <luiz@oxidecomputer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant