- 
                Notifications
    You must be signed in to change notification settings 
- Fork 105
virtio-queue: Add helpers for accessing queue information #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    163b256    to
    a32c2a3      
    Compare
  
    
              
                    lauralt
  
              
              reviewed
              
                  
                    Jan 25, 2022 
                  
              
              
            
            
6c2c4bc    to
    dd8ed18      
    Compare
  
    | PR's ready for review. | 
              
                    jiangliu
  
              
              reviewed
              
                  
                    Jan 28, 2022 
                  
              
              
            
            
| Thanks for improving the unit test logic:) | 
8c197cd    to
    27b233e      
    Compare
  
    
              
                    lauralt
  
              
              reviewed
              
                  
                    Jan 28, 2022 
                  
              
              
            
            
              
                    jiangliu
  
              
              previously approved these changes
              
                  
                    Jan 28, 2022 
                  
              
              
            
            
27b233e    to
    fc417a1      
    Compare
  
    | @lauralt PR updated! | 
              
                    lauralt
  
              
              previously approved these changes
              
                  
                    Jan 28, 2022 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements!
These helpers are meant to help crate's consumers getting and setting information about the queue. Signed-off-by: Sebastien Boeuf <[email protected]>
fc417a1    to
    fae1928      
    Compare
  
    
              
                    lauralt
  
              
              approved these changes
              
                  
                    Jan 28, 2022 
                  
              
              
            
            
              
                    rbradford
  
              
              approved these changes
              
                  
                    Jan 28, 2022 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
These helpers are meant to help crate's consumers getting and setting
information about the queue.
Signed-off-by: Sebastien Boeuf [email protected]