Skip to content

Unbundle params from output types #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Unbundle params from output types #328

wants to merge 7 commits into from

Conversation

djc
Copy link
Member

@djc djc commented Apr 13, 2025

This is an alternative direction to #326. From here, I think we can add a nice Issuer builder API.

@djc djc requested review from cpu and est31 April 13, 2025 13:09
@est31
Copy link
Member

est31 commented Apr 13, 2025

I like this one better than #326, but not sure if it has some negative consequences if the params are not available for Certificate.

@djc
Copy link
Member Author

djc commented Apr 13, 2025

I like this one better than #326, but not sure if it has some negative consequences if the params are not available for Certificate.

The caller could always bundle up the params and the Certificate if they need both, right?

@djc
Copy link
Member Author

djc commented Apr 13, 2025

@est31 sorry, I just pushed a bunch more stuff -- will stop here and let you take another look.

@djc djc force-pushed the issuer branch 2 times, most recently from ef856b7 to 74e48d2 Compare April 13, 2025 19:31
@blheatwole
Copy link

I set my project to use rcgen = { version = "0.13", features = ["aws_lc_rs"], git = "https://github.com/rustls/rcgen", branch="issuer"} which put me at 9e88850.

After a few updates I was able to successfully sign using a mock Key Vault. I'm working on confirming with the real Azure Key Vault.

@cpu
Copy link
Member

cpu commented Apr 16, 2025

I'll give this a review by EOW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants