Change is_selected() to use selectedIndex property for selection instead of $.val() #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of $.val() Disabled select might not show the selected value due to $.val() returning null if the select is disabled, see: http://bugs.jquery.com/ticket/13097.
|
Looks good to me. A few questions:
|
|
Yes, might be better as a fallback solution... selectedIndex will return the first selected option for multiple selects so in that case it's best to walk the options list and gather the selected ones to an array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled select might not show the selected value due to $.val() returning null if the select is disabled, see: http://bugs.jquery.com/ticket/13097.