Source class updates and tests #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: langleyreview <[email protected]>
…ew-directory-claude-4.5-sonnet-thinking-1d91 Document codebase in new directory
Co-authored-by: langleyreview <[email protected]>
Co-authored-by: langleyreview <[email protected]>
Co-authored-by: langleyreview <[email protected]>
Co-authored-by: langleyreview <[email protected]>
- Add override keywords to IsotropicHeat and IsotropicLinearThermoelasticity to properly override pure virtual methods from base classes - Update SWIG interface files to include all overridden virtual methods to prevent compilation errors when generating Python bindings
- Remove constructors from abstract base classes RheologyHeat and RheologyThermoelasticity to prevent SWIG from generating code that tries to instantiate abstract classes - Remove kernel methods that return function pointers (PetscPointFn*, PetscPointJac) from concrete classes - these are internal implementation details that cannot be properly wrapped by SWIG - Keep only the methods that can be properly exposed to Python
Co-authored-by: langleyreview <[email protected]>
…-thermal-physics-model-claude-4.5-opus-high-thinking-c210 Implement and test new thermal physics model
Co-authored-by: langleyreview <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 9. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Owner
Author
|
@copilot fix merge conflicts |
|
@rwalkerlewis I've opened a new pull request, #14, to work on those changes. Once the pull request is ready, I'll request review from you. |
Resolve merge conflicts with origin/main for thermal physics integration
rwalkerlewis
force-pushed
the
point_source_merge
branch
from
cd7e182 to
a3ce73d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates source class with
main, refines its Python API, and adds comprehensive unit, MMS, and full-scale tests for improved code quality and reliability.The rebase involved resolving
Makefile.amconflicts to properly integrate both thescales(from upstream) andsources(from this branch) modules, along with a C++ conflict inDSLabelAccess.icc. The source class cleanup addressed legacy references and improved consistency. New tests cover various wavelet types (Ricker, Square, Gaussian) across unit, MMS, and full-scale simulations, ensuring robust behavior.