FontAwesome: Reorder some glyphs #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reporting! I guess the reason is that FA comes now with 3 sets of icons and we select one of the sets for each codepoint (script Let me quickly check them all (again)
Action plan
|
[why] The open variants of circle_xmark and circle_check are missing. [how] Rename the filled versions to their old (i.e. FA 4.2) names (remove_sign and ok_sign) and let the open (regular) variants find their place automatically. Because we now have two more icons that would move all codepoints we can either drop the icons that occupied the circle_xmark and circle_check codepoints before, or we move the to the end (unpatched yet) region. As these are just some more arrows, we drop them. Dropped: F30B F05C solid/right-long.svg F30C F05D solid/up-long.svg New: F05C F05C regular/circle-xmark.svg F05D F05D regular/circle-check.svg Renamed: RENAME circle_xmark to remove_sign (F057) RENAME circle_check to ok_sign (F058) Signed-off-by: Fini Jastrow <[email protected]>
[why] When creating the renaming table the wrong number has been entered (twice the same). [how] Correct the renaming thereby making the renamed icon visible. The icon that has been 'kicked out' is moved to the end of the patched block. New: F0E6 F0E6 regular/comments.svg Moved: F374 EFC2 brands/avianex.svg (was previously on F0E6) Renamed: RENAME comments_o to comment_o (F0E5) Signed-off-by: Fini Jastrow <[email protected]>
youtube and cloudsmith should change their codepoints, because youtube occupies a 'lesser' youtube codepoint and yields a 'better' codepoint to cloudsmith. Better means the icon looks more like in FA 4. Also swap the devices icons that in 4 showed a screen and now it is filled. [how] The mechanics is a bit ... ugly. Signed-off-by: Fini Jastrow <[email protected]>
|
[why] F1DB had an open circle, called circle-thin. That must now come from the regular set. Unfortunaly circle_o at F10C already is also the same regular set icon. And we try to prefer the solid set if a regular set has been used already. [how] Add one specific exception to the rule :-( Signed-off-by: Fini Jastrow <[email protected]>
[why] Previously we had icons with an open screen and a button, now it is filled. [how] Swap the icons with the open icons at completely different codepoints. Signed-off-by: Fini Jastrow <[email protected]>
[why] We do not want to break the Fira progress icons, but on the other hand these are so few icons that we can not keep the whole 0x0100 block unoccupied. So we just leave a small gap in the FontAwesome codepoints. [how] Be careful, the current code moves the icons 'to the back', which will be different if we ever update FontAwesome. The code will break (reassign a lot codepoints) then. Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
Don't forget to run against the v3.1.1 glyphnames.json. Signed-off-by: Fini Jastrow <[email protected]>
[why] The glyphs can look a bit small(er) when used unscaled, for example in a Nerd Font Propo font. Note that some icons indeed got smaller, but in general the generated font is a bit smaller than before. Related: #1588 Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
3 tasks
hasecilu
reviewed
Apr 8, 2024
|
@hasecilu Thanks for having a look! 💚 This release seems to have less problems than others, still not many problems reported 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #1563 (comment)
From @hasecilu
More details in the comments.
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Fixes: #1588
Fixes: #1593
Screenshots (if appropriate or helpful)