Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-patcher: don't double-shrink heavy angle brackets #1617

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

gibfahn
Copy link
Contributor

@gibfahn gibfahn commented Apr 22, 2024

Fixes: #1611

Directly copied from #1611 (comment)

Description

Ah, the heavy brackets are now two times shrunken, there was an old rule that already sized them down relative to the full cell:

image

The rule needs to be changed to ^pa1! ....

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

Restores heavy angle brackets to the size they were in 3.1.1

How should this be manually tested?

Check size of heavy angle brackets before and after this change.

What are the relevant tickets (if any)?

#1611

Screenshots (if appropriate or helpful)

3.1.1 3.2.1
3.1.1 3.2.1

@Finii
Copy link
Collaborator

Finii commented Apr 23, 2024

Test ✔️

image

@Finii Finii merged commit 9e0ca39 into ryanoasis:master Apr 23, 2024
4 checks passed
@Finii
Copy link
Collaborator

Finii commented Apr 23, 2024

@allcontributors please add @gibfahn for code

Copy link
Contributor

@Finii

I've put up a pull request to add @gibfahn! 🎉

@gibfahn gibfahn deleted the patch-1 branch April 23, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

U+276F prompt character (❯) got smaller between 3.1.1 and 3.2.1
2 participants