-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add markdownlint configuration #1666
Conversation
Added `.markdownlint.yml` and `.prettierrc` configuration files to establish and maintain uniform coding and Markdown styling conventions across the project. These configurations enforce rules such as consistent line lengths, the use of semi-colons, and the handling of inline HTML and link fragments in Markdown, ensuring readable and maintainable documentation and codebase. Moreover, revised the `CHANGELOG.md` section header in `.versionrc` for better clarity and readability, aligning with markdownlint's recommendations. This initiative aims to minimize style discrepancies and improve code readability, facilitating a smoother collaboration process. It is an essential step towards a more structured and efficient development workflow, acknowledging that consistency is key to a project's long-term success. Related: ryanoasis#1665
I'm working on it right now. These two files are enough for initial configuration. I think it would be good to add the configuration file to the editor as well. Now I'm doing formatting on all the markdown files in the project and checking if everything is correct. Sure, I'll let you know today so you can check. |
Added `.editorconfig` file to ensure consistency in coding styles for various languages and aligned with project-wide settings across different configuration files (e.g., .prettierrc, .eslintrc) on your editor of choice. This file is intended to ensure a consistent coding style for various files in the project for the selected code editor. It can be used in _Vim_, _Neovim_, _Visual Studio Code_, and other IDEs you use for editing code. Adjusted indentation, max line lengths, and added comments for clarity.
I think it would also be good to organize the names of Markdown files, especially the main readme.md file, which according to standards should be named with capital letters. If the file is named in uppercase, it is more visible and displayed as one of the first in the list in the editor. The same applies in the terminal. I think it would be appropriate to first rename with this @Finii do you have any objections to me making this change? Pleas, let me know! Thanks! |
@allcontributors please add @mdsanima for maintenance |
I've put up a pull request to add @mdsanima! 🎉 |
Of course the is no such standard, it is just a custom from ancient times - I remember pulling packets from the local BBS and unpacking those, and the most relevant documentation was in CAPS named files to find them quickly. I think (hope) I changed all readmes in the meantime to Ah, yes, here they are:
We did use But this should probably also be changed to CAPs:
ButBut I would leave the 'root'
Well, I edit with I would just add the linter to the CI so that any changes will be checked and reported, so that authors can adapt their PRs accordingly. Like we do with I did not test how Edit: Correct typo and improve formatting |
Thanks for your patience, I had a few other tasks to do in the meantime, but now I'm back to this. Ok, I think this can be checked now, in the next pull request I will add formatting. |
The default README.md file on GitHub is created in uppercase when you create a new repository. |
Hello @Finii, I think this is ready for the reviews. |
Ah, thanks! |
Ok sure, I'll do that. Soon I'll add the modified Markdown files to this PR. I was going to create a separate pull request for formatting, but if you prefer that I do it here, no problem. |
Although this seems to be desirable I have the feeling this is not ready and/or the resulting changes can not be reviewed. |
No progress since July, closing for now. |
Added
.markdownlint.yml
and.prettierrc
configuration files to establish and maintain uniform coding and Markdown styling conventions across the project.These configurations enforce rules such as consistent line lengths, the use of semi-colons, and the handling of inline HTML and link fragments in Markdown, ensuring readable and maintainable documentation and codebase. Moreover, revised the
CHANGELOG.md
section header in.versionrc
for better clarity and readability, aligning with markdownlint's recommendations.This initiative aims to minimize style discrepancies and improve code readability, facilitating a smoother collaboration process. It is an essential step towards a more structured and efficient development workflow, acknowledging that consistency is key to a project's long-term success.
Related: #1665
Requirements / Checklist
Issue number where discussion took place: #xxx