smr_alignment: Improve MetricAlignmentOptimizer#20
Merged
Conversation
This adds several improvements to the `MetricAlignmentOptimizer` that I realized as I was experimenting on real world data. - Add timing + run stats, - Make solver optional (to let `cvxpy` decide which one to use) - Apply unified score as working weight (which aligns the applied edge weight with the objective actually optimized, seems like a good idea to me... (The old way obviously was a bug)) - Keep pre-optimization weight for reference
s-heppner
force-pushed
the
Fix/metric_alignment
branch
from
715e39a to
1ef7904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds several improvements to the
MetricAlignmentOptimizerthat I realized as I was experimenting on real world data.cvxpydecide which one to use)