Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain extraction when --dns flag is used #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morkot
Copy link

@morkot morkot commented Jan 21, 2020

Description

Examples of failure

Tested on

os: MacOS 10.14.4
python: 3.7.3

Dependencies

pytest for running unit tests (development only)

* function top_level failed on domains like co.uk
* see more info https://en.wikipedia.org/wiki/Second-level_domain
@morkot morkot mentioned this pull request Jan 22, 2020
@morkot
Copy link
Author

morkot commented Jan 24, 2020

@s0md3v could you take a look on this one?
Also, seems like the build is failing due to site unavailability.

@morkot morkot requested a review from s0md3v February 5, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant