Add memory limited FileBasedCacheManager #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonKaunismaa
changed the title
johnh-ant
reviewed
Jun 17, 2025
Contributor
|
ty, this seems v useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with really large caches, especially with multiple processes, you can get OOMs that fail somewhat silently (i.e. I had an issue where API requests would sit forever, and I spent a bunch of time thinking it was something wrong with the API itself, but it turns out that the OS was killing the process and for some reason this didn't actually return me to the terminal). This PR lets you set a maximum size in MB for the cache if desired, to avoid these OOMs. Simply set the
max_mem_usage_mbin your ExperimentConfig object. (only applies to FileBasedCacheManager caches)