Skip to content

Conversation

xcaruso
Copy link
Contributor

@xcaruso xcaruso commented Jul 17, 2025

We add a constructor for instantiating easily the Carlitz module.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#40430, #40436

Copy link
Contributor

@kryzar kryzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in the diff.

Copy link

github-actions bot commented Aug 4, 2025

Documentation preview for this PR (built with commit b201d77; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@kryzar kryzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely.

(Failing tests (stuff in src/sage/interfaces/gap.py or internal cuisine) are unrelated to the PR.)

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 12, 2025
sagemathgh-40433: Constructor for the Carlitz module
    
We add a constructor for instantiating easily the Carlitz module.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40430, sagemath#40436
    
URL: sagemath#40433
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 13, 2025
sagemathgh-40433: Constructor for the Carlitz module
    
We add a constructor for instantiating easily the Carlitz module.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40430, sagemath#40436
    
URL: sagemath#40433
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière, Xavier Caruso
@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 20, 2025

Don't understand where the error on cyclic_covers/charpoly_frobenius.py comes from but it is very likely independant of this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 21, 2025
sagemathgh-40433: Constructor for the Carlitz module
    
We add a constructor for instantiating easily the Carlitz module.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40430, sagemath#40436
    
URL: sagemath#40433
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière, Xavier Caruso
@vbraun vbraun merged commit e55feb2 into sagemath:develop Aug 27, 2025
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants