cleanup and annotations in congroup_gammaH.py #40437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
Aug 4, 2025
|
Documentation preview for this PR (built with commit c8b7f68; changes) is ready! 🎉 |
tscrim
approved these changes
Aug 18, 2025
Co-authored-by: Travis Scrimshaw <[email protected]>
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40437: cleanup and annotations in congroup_gammaH.py Did some review of the file `src/sage/modular/arithgroup/congroup_gammaH.py` to enhance the code and add annotations. (also a tiny change in another file) ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40437 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some review of the file
src/sage/modular/arithgroup/congroup_gammaH.pyto enhance the code and add annotations.(also a tiny change in another file)
📝 Checklist