simplify some nested for loops #40439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantepse
reviewed
Jul 18, 2025
| @@ -955,7 +955,9 @@ def maximal_order(self, take_shortcuts=True, order_basis=None): | |||
| Order of Quaternion Algebra (-22, 210) with base ring Rational Field | |||
| with basis (1, i, 1/2*i + 1/2*j, 1/2 + 17/22*i + 1/44*k) | |||
|
|
|||
| sage: for d in ( m for m in range(1, 750) if is_squarefree(m) ): # long time (3s) | |||
| sage: for d in range(1, 700): # long time (3s) | |||
There was a problem hiding this comment.
To make the test timing comparable with past versions I would keep the 750, but that's really only a personal opinion, feel free to ignore!
Suggested change
| sage: for d in range(1, 700): # long time (3s) | |
| sage: for d in range(1, 750): # long time (3s) |
|
nice! |
|
I would myself use rather 600 than 750. So I put 700 as a middle step. In principle, tests are not supposed to be long and complicated. |
So, then use a number such that it is no longer a long test. In a fresh session, seems to be on the very safe side. Besides, I think that would also be the better form of the example, more precisely sage: Q = QuaternionAlgebra
sage: all(Q(d).maximal_order(take_shortcuts=False).is_maximal()
....: for d in range(1, 350) if is_squarefree(d)) |
|
d'accord ! Voilà |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 20, 2025
sagemathgh-40439: simplify some nested for loops either using walrus or simpler syntax ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40439 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
either using walrus or simpler syntax
📝 Checklist