Skip to content

Conversation

fchapoton
Copy link
Contributor

  • using "indirect doctest"
  • add some typing annotations
  • remove unused imports
  • break very long lines

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 26, 2025
sagemathgh-40464: some details in binary quadratic forms / class groups
    
- using "indirect doctest"
- add some typing annotations
- remove unused imports
- break very long lines

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40464
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 26, 2025
sagemathgh-40464: some details in binary quadratic forms / class groups
    
- using "indirect doctest"
- add some typing annotations
- remove unused imports
- break very long lines

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40464
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 27, 2025
sagemathgh-40464: some details in binary quadratic forms / class groups
    
- using "indirect doctest"
- add some typing annotations
- remove unused imports
- break very long lines

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40464
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 28, 2025
sagemathgh-40464: some details in binary quadratic forms / class groups
    
- using "indirect doctest"
- add some typing annotations
- remove unused imports
- break very long lines

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40464
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 29, 2025
sagemathgh-40464: some details in binary quadratic forms / class groups
    
- using "indirect doctest"
- add some typing annotations
- remove unused imports
- break very long lines

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40464
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit 1bd6ba7 into sagemath:develop Aug 2, 2025
21 of 24 checks passed
@fchapoton fchapoton deleted the details_bqf branch August 18, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants