Skip to content

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Jul 21, 2025

trying to move away from Dokchitser's auld scripts

  • no longer allowing their use for elliptic curves
  • same in L-function of number fields
  • same in L-function of the modular form Delta
  • trying to get rid of them for Eisenstein L-functions
  • trying to get rid of them for Gross-Zagier L-functions

help welcome !

Note: the handling of general modular forms is best kept for another pull request.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@fchapoton
Copy link
Contributor Author

@JohnCremona : I would appreciate help from Lmfdb and Pari experts on the case of Eisenstein series

@fchapoton
Copy link
Contributor Author

fchapoton commented Jul 21, 2025

Is this a failure or an improvement ?


File "src/sage/modular/modform/eis_series.py", line 422, in sage.modular.modform.eis_series.?
Failed example:
    L(2)
Expected:
    -5.0235535164599797471968418348135050804419155747868718371029
Got:
    -5.0235535164599799477225675531508296063579361580211036347215

ANSWER: this was a failure

@JohnCremona
Copy link
Member

I'll look but not until Thursday

@fchapoton
Copy link
Contributor Author

fchapoton commented Jul 22, 2025

now there are some issues with the handling of bit precision..

and more precisely with the number of terms required, that are insufficient to check the functional equation

@fchapoton
Copy link
Contributor Author

I am also annoyed because for Eisenstein series the only path I found to relative success was to pass the residue of the uncompleted L-function to pari, instead of the simpler residues of the completed L-function.

@fchapoton
Copy link
Contributor Author

fchapoton commented Jul 22, 2025

now remains only a failure

Expected:
    -5.0235535164599797471968418348135050804419155747868718371029
Got:
    -5.0235535164599800135315437325373372537800575000382643457910

which is apparently really a failure, as the expected value is

sage: f=zeta(2)*zeta(-17)
sage: f.n(200)
-5.0235535164599797471968418348135050804419155747868718371029

@fchapoton
Copy link
Contributor Author

It seems to me that the handling of precision is still faulty, but I cannot investigate further.

@user202729
Copy link
Contributor

the precision issues are mostly correct already? maybe just one # rel tol 1e-14 at L(2) + E.lseries_gross_zagier(A^2)(2) (if no explicit precision parameter are passed then one can expect roughly 53 bits)

@fchapoton
Copy link
Contributor Author

@JohnCremona and @roed314 : would you please advertise to LMFDB people what I am trying to do here, namely get rid of the original Dokchitser scripts in favor of PARI ?

Copy link

github-actions bot commented Aug 26, 2025

Documentation preview for this PR (built with commit abe56d2; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@JohnCremona
Copy link
Member

Documentation preview for this PR (built with commit af8a5e5; changes) is ready! 🎉 This preview will update shortly after each push to this PR.

I will leave this to @roed314 since he is, and I am no longer, a managing editor of LMFDB

@roed314
Copy link
Contributor

roed314 commented Aug 26, 2025

I've advertised this PR on the LMFDB Zulip, and also sent @fchapoton an invitation to join (let me know if I got your address wrong: I took it from the Sage Zulip).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants