npm: update express to 5.1

[haraldschilly]

Ref #8529

This almost works. What's left to fix is the next api v2. That "Cannot set property query..." error mentioned below is because express makes it read-only.

---

This is a note from earlier ...

This gives me headaches. The core issue is there are no longer those flexible regex routes. Rather a more strict system, i.e. path-to-regexp updated. One place where I'm stuck is the proxy setup for projects. The idea I have is to create a small middleware, which checks if the supposed project ID is actually an UUID – otherwise to pass on internally to the next route. router level middleware This also implies that the "string-regex" passed to initUpgrade needs to be different than the more general path for the route.

What I got to work is e.g. the index page, loading frontend, redirecting to specific frontend pages, etc. The websocket connection doesn't work though. Some detail must be off.

Also, just while running the dev server, I get weird sudden crashes like that:

Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues
Message:  should mgm exist
Location: crates/rspack_core/src/compiler/make/cutout/fix_issuers.rs:58

What I haven't even started to look into is the api/v2 endpoint:

 ✓ Compiled /api/v2 in 39s (10082 modules)
 ⨯ [TypeError: Cannot set property query of #<IncomingMessage> which has only a getter] {
  page: '/api/v2'
}

[williamstein]

Any new thoughts about this?

[haraldschilly]

Any new thoughts about this?

no, unfortunately not. there is certainly work left to do, though.

[haraldschilly]

Any new thoughts about this?

no, unfortunately not. there is certainly work left to do, though.

ok wait, I'll check again. I think I got something to work, but I was a bit surprised in the end. There are probably aspects left I didn't test, so, that's the "unknown" for me here.

[williamstein]

I watched a talk on youtube from nodeconf eu 24 about this express update. I guess there had been no major updates in ~10 years, or something, and somebody got inspired to modernize express, which finally led to a 5.x release. So it could indeed be challenging!