Skip to content

fix: Instance-Accent PWA Titlebar Wash (Mock Parity)#436

Merged
sahil-noon merged 2 commits into
mainfrom
260722-y5c3-instance-accent-titlebar-wash
Jul 22, 2026
Merged

fix: Instance-Accent PWA Titlebar Wash (Mock Parity)#436
sahil-noon merged 2 commits into
mainfrom
260722-y5c3-instance-accent-titlebar-wash

Conversation

@sahil-noon

Copy link
Copy Markdown
Collaborator

Meta

Change ID Type Confidence Plan Review
y5c3 fix 4.9/5.0 5/5 tasks, 11/11 acceptance ✓ ✓ 1 cycle
Impact +/− Net
raw +327 / −18 +309
true +36 / −14 +22
└ impl +29 / −13 +16
└ tests +7 / −1 +6

excludes fab/, docs/ · generated by fab-kit v2.16.5

Pipeline: intake ✓ → apply ✓ → review ✓ → hydrate ✓ → ship → review-pr

Summary

PR #435 wrote the full contrast-guarded accent hex (stripeHex) into the theme-color meta, so an installed PWA's titlebar painted the entire chrome in a loud, fully saturated hue — and the deliberate 2px accent stripe below it became invisible, since it abutted a titlebar of the identical color. This restores the reviewed design mock: a subtle dark blend of the accent into the theme background for the titlebar, with the full-brightness stripe visible directly beneath it.

Changes

  • deriveAccentHexes gains a third derived hex — the meta/titlebar hex
  • The blended titlebar hex — NOT stripeHex — becomes the meta content and the echo hex
  • Unchanged — the other surfaces and the resolution chain
  • Tests to update

@sahil-noon
sahil-noon marked this pull request as ready for review July 22, 2026 10:35
@sahil-noon
sahil-noon merged commit f5ebfbe into main Jul 22, 2026
6 checks passed
@sahil-noon
sahil-noon deleted the 260722-y5c3-instance-accent-titlebar-wash branch July 22, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants