refactor: Automatic Safe-Name Conversion at Naming Entry Points#441
Merged
Conversation
sahil-noon
marked this pull request as ready for review
July 22, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta
ln4nexcludes
fab/,docs/· generated by fab-kit v2.16.5Pipeline: intake ✓ → apply ✓ → review ✓ → hydrate ✓ → ship → review-pr
Summary
run-kit's name validation was inconsistent and leaky:
ValidateNameallowed spaces in session/window names (which then broke tmux CLI targeting, session-group naming, and URL routing), while server names were rejected outright on a typed space. This change adds automatic, live, per-name-kind safe-name conversion in the frontend (e.g. "My problem" → "My_problem" as you type) and tightens the backend so new-name validation rejects spaces as a real contract, while existing-name lookups stay permissive for names created outside run-kit.Changes
app/frontend/src/lib/names.ts(new), promotingtoTmuxSafeName()out ofcreate-session-dialog.tsxinto one canonical transform per name kind (toSafeSessionName,toSafeWindowName,toSafeServerName,toSafeWorktreeName)WindowHeadinginline rename, server-name input, worktree-name fieldValidateNametightens for NEW names (rejects spaces); existing-name lookups stay on the permissive validator so pre-existing spacey names remain operablewindow-heading.spec.ts+.spec.md,sync-latency.spec.ts+.spec.md)