fix: code-server respawn review follow-ups (from #583 Copilot review) - #584
Merged
Conversation
Collaborator
Author
|
Added two production fixes observed on a real install attempt:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #583 was merged before its Copilot review fixes were pushed, stranding the fix commit on the merged branch. This re-lands those three review fixes on top of main.
Changes
respawnOutcomegains an explicitrespawnFailedzero value — error paths no longer return a zero value that reads as "done" (Copilot comment oncode_server.go:216)migrateForeignCodeServerSessionno longer treats an unresolvable managed binary as "ours" — the no-anchor case now prints a note instead of silently skipping the migration check (code_server.go:277)daemon.CodeServerSessionCommanddoc comment states the daemon-liveness gate obligation — callers must gate ondaemon.IsRunningbefore calling (tmux probes on a dead socket birth a server) (codeserver.go:366)