Blacklist for Window Controls#49
Open
4m2c4bl3 wants to merge 4 commits into
Open
Conversation
4m2c4bl3
force-pushed
the
feature/add_blacklist
branch
from
f419c24 to
fd52c67
Compare
Owner
|
Thank you for your effort and time @4m2c4bl3 I need to catch up with stuff but hopefully soon to review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a good fix per say, it requires users to have a certain level of technical knowledge, but I put in a blacklist to avoid window-controls from interfering with certain modules.
Perhaps it could be improved by having the settings option be a dropdown list of all active module ids to select from? The selections could go into an array and be rendered as chips, that you could click on to remove. It would remove user error. But that's beyond what I know how to implement in foundry right now.
Solving my own bug (and probably others) : #48