Repository navigation
Fix startup crash on develop and add CI - #53
Merged
saihgupr merged 2 commits intoNov 1, 2026
Merged
Conversation
4233c03 declared assertAutoManaged a second time. server.js is an ES module, so Node rejects the duplicate and the add-on fails to start on develop. Keep one definition, carrying statusCode 403, and let the retention endpoints return it like the reset and flush endpoints do. Add a CI workflow that syntax-checks the server sources and runs the manual mode tests on pushes to main/develop and on pull requests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
developcurrently fails to start. 4233c03 added a secondassertAutoManagednext to the one from #50, and sinceserver.jsis an ES module Node rejects it before anything runs:npm testcatches this (all 4 tests fail), but nothing runs the tests on push or PR yet.Changes
assertAutoManaged, with thestatusCode = 403from 4233c03. The three retention endpoints now pass that status through like hard reset, soft reset and flush already do, instead of returning 500 in manual mode.main/developand on every PR:npm ci,node --checkon the server sources,npm test.Verification
developwithout this fix:npm testgives 0 passed, 4 failed (SyntaxError)Side note, not changed here
POST /api/retention/cleanupis registered twice (around lines 3315 and 3928). Express only ever runs the first handler, so the second one is dead code.🤖 Generated with Claude Code