Bump go directive to 1.26.5 to clear GO-2026-5856#113
Merged
Conversation
govulncheck flags GO-2026-5856, a crypto/tls vulnerability in the Go standard library, found in go1.26.4 and fixed in go1.26.5. CI reads the toolchain from the go directive via go-version-file, so the scan builds against the affected standard library and fails. Bump the directive to 1.26.5. Verified locally that govulncheck reports no vulnerabilities under go1.26.5.
The go directive bump to 1.26.5 outran the pinned golang:1.26.4-alpine base image, so the docker and smoke jobs could no longer satisfy the module's Go requirement. Bump the three Dockerfiles to golang:1.26.5-alpine and update the documented minimum and the install-script version checks to match. golang:1.26.5-alpine is published; the Go build succeeds under 1.26.5 with the current dependency set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is failing on the
govulncheckstep of the test job:This is a
crypto/tlsvulnerability in the Go standard library, not a dependency. CI resolves the toolchain from thegodirective in go.mod (go-version-file: go.modin ci.yaml and release.yaml), so the scan builds against the affected standard library.Bumps the directive from 1.26.4 to 1.26.5. Verified locally that
govulncheck ./...reports no vulnerabilities under go1.26.5, and that the build passes with the current dependency set.