Skip to content

Fix bugs in _score() method of Meteor class #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doiken23 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bugs in _score() method of Meteor class #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0627e3
:bug: fix encode/decode bug in _score()
doiken23 Nov 30, 2020
7f86b26
:bug: remove overlapped line
doiken23 Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions meteor/meteor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,12 @@ def _score(self, hypothesis_str, reference_list):
# SCORE ||| reference 1 words ||| reference n words ||| hypothesis words
hypothesis_str = hypothesis_str.replace('|||','').replace(' ',' ')
score_line = ' ||| '.join(('SCORE', ' ||| '.join(reference_list), hypothesis_str))
self.meteor_p.stdin.write('{}\n'.format(score_line))
stats = self.meteor_p.stdout.readline().strip()
self.meteor_p.stdin.write('{}\n'.format(score_line).encode())
stats = self.meteor_p.stdout.readline().decode().strip()
eval_line = 'EVAL ||| {}'.format(stats)
# EVAL ||| stats
self.meteor_p.stdin.write('{}\n'.format(eval_line))
score = float(self.meteor_p.stdout.readline().strip())
# bug fix: there are two values returned by the jar file, one average, and one all, so do it twice
# thanks for Andrej for pointing this out
score = float(self.meteor_p.stdout.readline().strip())
self.meteor_p.stdin.write('{}\n'.format(eval_line).encode())
score = float(self.meteor_p.stdout.readline().decode().strip())
self.lock.release()
return score

Expand Down