fix: e2e tests will run after publish @W-19756811@ #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, in the
publish-mcp-serverworkflow, ifupdate-dependencieswas skipped, then even ifpublish-serversucceeded, thee2e-testjob would also be skipped.This was due to a known-generally-but-forgotten-by-us-specifically quirk of Github Actions, wherein if a job is skipped, all subsequent jobs must have explicit
ifcriteria or else they will not run.This PR adds such criteria to
e2e-test, resolving the issue.See this proof-of-concept execution based on #349 .
What issues does this PR fix or reference?
@W-19756811@