Skip to content

fix(gates): repair the WASM smoke gates #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YoungSx merged 14 commits into from
Sep 5, 2026
Merged

fix(gates): repair the WASM smoke gates #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f21039d
test(gates): wait out the splash loader before pointer-driven steps
YoungSx Sep 5, 2026
df02745
test(gates): read combo box selection through the open dropdown
YoungSx Sep 5, 2026
a8b23f2
test(gates): assert the report card's modal round-trip, not the notic…
YoungSx Sep 5, 2026
e065f22
test(gates): drop the composer color assertion Skia cannot expose
YoungSx Sep 5, 2026
e8d9b78
test(gates): drive the cache retention field through its real editor
YoungSx Sep 5, 2026
2740a6e
test(gates): match the control the user is looking at, and read text …
YoungSx Sep 5, 2026
ec18ccc
test(gates): type with a real keyboard so the value reaches the ViewM…
YoungSx Sep 5, 2026
e5771c5
test(gates): stop the settings shell from replacing the page it just …
YoungSx Sep 5, 2026
77e7f1d
test(gates): drive the MCP settings page through the semantic tree
YoungSx Sep 5, 2026
26b7dd6
test(gates): observe the ACP flow through what the app actually exposes
YoungSx Sep 5, 2026
c88fb9a
fix(diagnostics): announce gamepad diagnostic values instead of their…
YoungSx Sep 5, 2026
e7508a9
test(gates): only press the notice's OK while it is still there
YoungSx Sep 5, 2026
46985b2
test: stop pinning the persistence smoke's source expressions
YoungSx Sep 5, 2026
54513b4
test(gates): activate the report card until its notice opens
YoungSx Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions SalmonEgg/SalmonEgg/Presentation/Views/Settings/DiagnosticsSettingsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@
<controls:ResponsiveFormRow.Value>
<TextBlock Text="{x:Bind ViewModel.GamepadDiagnostics.StatusText, Mode=OneWay}"
AutomationProperties.AutomationId="Diagnostics.GamepadStatus"
AutomationProperties.Name="Diagnostics.GamepadStatus"
AutomationProperties.Name="{x:Bind ViewModel.GamepadDiagnostics.StatusText, Mode=OneWay}"
Style="{StaticResource SettingsRowDescriptionTextStyle}"/>
</controls:ResponsiveFormRow.Value>
</controls:ResponsiveFormRow>
Expand All @@ -506,7 +506,7 @@
<controls:ResponsiveFormRow.Value>
<TextBlock Text="{x:Bind ViewModel.GamepadDiagnostics.ConnectedGamepadsText, Mode=OneWay}"
AutomationProperties.AutomationId="Diagnostics.GamepadStandardCount"
AutomationProperties.Name="Diagnostics.GamepadStandardCount"
AutomationProperties.Name="{x:Bind ViewModel.GamepadDiagnostics.ConnectedGamepadsText, Mode=OneWay}"
Style="{StaticResource SettingsRowDescriptionTextStyle}"/>
</controls:ResponsiveFormRow.Value>
</controls:ResponsiveFormRow>
Expand All @@ -524,7 +524,7 @@
<controls:ResponsiveFormRow.Value>
<TextBlock Text="{x:Bind ViewModel.GamepadDiagnostics.ConnectedRawControllersText, Mode=OneWay}"
AutomationProperties.AutomationId="Diagnostics.GamepadRawCount"
AutomationProperties.Name="Diagnostics.GamepadRawCount"
AutomationProperties.Name="{x:Bind ViewModel.GamepadDiagnostics.ConnectedRawControllersText, Mode=OneWay}"
Style="{StaticResource SettingsRowDescriptionTextStyle}"/>
</controls:ResponsiveFormRow.Value>
</controls:ResponsiveFormRow>
Expand All @@ -542,7 +542,7 @@
<controls:ResponsiveFormRow.Value>
<TextBlock Text="{x:Bind ViewModel.GamepadDiagnostics.InputSourceText, Mode=OneWay}"
AutomationProperties.AutomationId="Diagnostics.GamepadInputSource"
AutomationProperties.Name="Diagnostics.GamepadInputSource"
AutomationProperties.Name="{x:Bind ViewModel.GamepadDiagnostics.InputSourceText, Mode=OneWay}"
Style="{StaticResource SettingsRowDescriptionTextStyle}"/>
</controls:ResponsiveFormRow.Value>
</controls:ResponsiveFormRow>
Expand All @@ -560,7 +560,7 @@
<controls:ResponsiveFormRow.Value>
<TextBlock Text="{x:Bind ViewModel.GamepadDiagnostics.ActiveInputsText, Mode=OneWay}"
AutomationProperties.AutomationId="Diagnostics.GamepadActiveInputs"
AutomationProperties.Name="Diagnostics.GamepadActiveInputs"
AutomationProperties.Name="{x:Bind ViewModel.GamepadDiagnostics.ActiveInputsText, Mode=OneWay}"
Style="{StaticResource SettingsRowDescriptionTextStyle}"/>
</controls:ResponsiveFormRow.Value>
</controls:ResponsiveFormRow>
Expand All @@ -578,7 +578,7 @@
<controls:ResponsiveFormRow.Value>
<TextBlock Text="{x:Bind ViewModel.GamepadDiagnostics.ThumbstickText, Mode=OneWay}"
AutomationProperties.AutomationId="Diagnostics.GamepadThumbstick"
AutomationProperties.Name="Diagnostics.GamepadThumbstick"
AutomationProperties.Name="{x:Bind ViewModel.GamepadDiagnostics.ThumbstickText, Mode=OneWay}"
Style="{StaticResource SettingsRowDescriptionTextStyle}"/>
</controls:ResponsiveFormRow.Value>
</controls:ResponsiveFormRow>
Expand All @@ -596,7 +596,7 @@
<controls:ResponsiveFormRow.Value>
<TextBlock Text="{x:Bind ViewModel.GamepadDiagnostics.StandardGamepadsText, Mode=OneWay}"
AutomationProperties.AutomationId="Diagnostics.GamepadStandardDetails"
AutomationProperties.Name="Diagnostics.GamepadStandardDetails"
AutomationProperties.Name="{x:Bind ViewModel.GamepadDiagnostics.StandardGamepadsText, Mode=OneWay}"
Style="{StaticResource SettingsRowDescriptionTextStyle}"
TextWrapping="WrapWholeWords"/>
</controls:ResponsiveFormRow.Value>
Expand All @@ -615,7 +615,7 @@
<controls:ResponsiveFormRow.Value>
<TextBlock Text="{x:Bind ViewModel.GamepadDiagnostics.RawControllersText, Mode=OneWay}"
AutomationProperties.AutomationId="Diagnostics.GamepadRawDetails"
AutomationProperties.Name="Diagnostics.GamepadRawDetails"
AutomationProperties.Name="{x:Bind ViewModel.GamepadDiagnostics.RawControllersText, Mode=OneWay}"
Style="{StaticResource SettingsRowDescriptionTextStyle}"
TextWrapping="WrapWholeWords"/>
</controls:ResponsiveFormRow.Value>
Expand Down
88 changes: 8 additions & 80 deletions scripts/gates/wasm-focus-boundary-smoke.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
} from "./wasm-smoke-lib/browser-app.mjs";
import {
focusVisibleControl,
revealCollapsedSection,
readControlState,
scrollToVisibleControl,
waitForBodyText,
Expand Down Expand Up @@ -71,86 +72,13 @@ try {

async function revealGamepadDiagnosticsSection(page) {
await waitForBodyText(page, diagnosticsPagePattern, "diagnostics settings page before gamepad reveal");

const headerTargets = {
labels: ["Gamepad input", "手柄输入", "Compatibility monitor", "兼容性监测"],
automationIds: ["Diagnostics.GamepadMonitorHeader"]
};

for (let attempt = 0; attempt < 20; attempt += 1) {
const state = await readControlState(page, gamepadStart);
if (state.found) {
return;
}

// Uno Expander does not reliably expand from synthetic element.click() in
// BrowserWasm. Use a real Playwright mouse click on the Gamepad expander
// toggle (or the nearest ExpanderToggleButton whose text mentions gamepad).
const togglePoint = await page.evaluate(() => {
const normalize = value => (value ?? "").replace(/\s+/g, " ").trim().toLowerCase();
// Fallback rectangle scanner: match the id contract, not the name. These buttons carry no
// AutomationProperties.Name, so their aria-label only *coincidentally* equals the automation
// id (the nameless fallback); xamlautomationid keeps working whether or not a name is added.
const start = document.querySelector('[xamlautomationid="Diagnostics.GamepadStart"]');
const expander =
start?.closest(".uno-expander")
?? start?.closest("[class*='Expander']")
?? start?.closest("details")
?? null;
const ownedToggle =
expander?.querySelector('[xamlautomationid="ExpanderToggleButton"], button, [role="button"], .uno-expanderheader, summary')
?? null;
if (ownedToggle) {
const rect = ownedToggle.getBoundingClientRect();
if (rect.width > 0 && rect.height > 0) {
return {
x: rect.left + rect.width / 2,
y: rect.top + rect.height / 2,
source: "owned-toggle"
};
}
}

const toggles = Array.from(
document.querySelectorAll('[xamlautomationid="ExpanderToggleButton"], button, [role="button"], summary'));
for (const toggle of toggles) {
const text = normalize(toggle.textContent);
if (text.includes("gamepad") || text.includes("手柄") || text.includes("compatibility monitor") || text.includes("兼容性监测")) {
const rect = toggle.getBoundingClientRect();
if (rect.width > 0 && rect.height > 0
&& rect.left >= -1
&& rect.top >= -1
&& rect.left <= innerWidth
&& rect.top <= innerHeight) {
return {
x: rect.left + rect.width / 2,
y: rect.top + rect.height / 2,
source: "text-toggle"
};
}
}
}

return null;
});

if (togglePoint) {
await page.mouse.click(togglePoint.x, togglePoint.y);
await page.waitForTimeout(500);
const afterToggle = await readControlState(page, gamepadStart);
if (afterToggle.found) {
return;
}
}

await scrollToVisibleControl(page, headerTargets);
await scrollToVisibleControl(page, gamepadStart);
await page.mouse.wheel(0, 700);
await page.waitForTimeout(300);
}

const state = await readControlState(page, gamepadStart);
throw new Error(`Diagnostics gamepad section was not reachable in BrowserWasm. State=${JSON.stringify(state)}`);
await revealCollapsedSection(
page,
// The Expander header button, matched by the name a screen reader announces. Its automation id
// belongs to the header content inside it, which is a 0x0 group that cannot be toggled.
{ labels: ["Gamepad input", "手柄输入"], automationIds: [] },
gamepadStart,
"gamepad diagnostics section");
}


Expand Down
170 changes: 25 additions & 145 deletions scripts/gates/wasm-gamepad-boundary-smoke.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
} from "./wasm-smoke-lib/browser-app.mjs";
import {
clickVisibleControl,
revealCollapsedSection,
readControlState,
scrollToVisibleControl,
waitForBodyText,
Expand Down Expand Up @@ -587,93 +588,47 @@ async function expectControlText(page, options, pattern, label) {
return state;
}

// Read the value off the field's own node. Skia's semantic tree is flat - the value is not a child of
// the node carrying the automation id - so the value has to be on that node itself, which is what the
// accessible name is for: these fields now bind their name to the text they render, so a screen reader
// and this check read the same thing. The old version hunted for a laid-out leaf node containing the
// text, which could not work, because value nodes are not laid out.
async function waitForControlText(page, options, pattern, label, timeoutMs = 30_000) {
const deadline = Date.now() + timeoutMs;
let lastState = null;

while (Date.now() < deadline) {
await scrollToVisibleControl(page, options, 2_000).catch(() => false);
lastState = await readControlState(page, options);
const text = (lastState?.text || lastState?.aria || "").trim();
const text = (lastState?.aria || lastState?.text || "").trim();
if (lastState?.found && pattern.test(text)) {
return lastState;
}

// BrowserWasm TextBlocks often keep AutomationId off the DOM (no aria-label).
// Fall back to leaf text in the expanded Gamepad section for diagnostics projection.
// Do not require the leaf to already be in the viewport; scroll it into view first.
const fallback = await page.evaluate(({ patternSource, flags }) => {
const re = new RegExp(patternSource, flags);
const isLaidOut = element => {
const rect = element.getBoundingClientRect();
const style = getComputedStyle(element);
return rect.width > 0
&& rect.height > 0
&& style.display !== "none"
&& style.visibility !== "hidden"
&& Number(style.opacity || "1") > 0;
};

const start = document.querySelector('[xamlautomationid="Diagnostics.GamepadStart"]');
const scope =
start?.closest(".uno-expander")
?? start?.closest("[class*='Expander']")
?? document.body;
const leaves = Array.from(scope.querySelectorAll("*"))
.filter(element => element.children.length === 0)
.filter(isLaidOut);

for (const element of leaves) {
const text = (element.textContent || "").replace(/\s+/g, " ").trim();
if (!text || !re.test(text)) {
continue;
}

element.scrollIntoView({ block: "center", inline: "nearest" });
const rect = element.getBoundingClientRect();
return {
found: true,
enabled: true,
text,
aria: element.getAttribute("aria-label") || "",
x: rect.left + rect.width / 2,
y: rect.top + rect.height / 2,
via: "leaf-text-fallback"
};
}

return { found: false, enabled: false };
}, { patternSource: pattern.source, flags: pattern.flags });

if (fallback?.found) {
return fallback;
}

await page.waitForTimeout(100);
await page.waitForTimeout(200);
}

throw new Error(`Timed out waiting for ${label}. State=${JSON.stringify(lastState)}`);
}

async function refreshGamepadDiagnostics(page, label) {
// Real Playwright click by id contract (xamlautomationid), not by name: this button carries no
// AutomationProperties.Name, so its aria-label only coincidentally equals the automation id.
const refresh = page.locator('[xamlautomationid="Diagnostics.GamepadRefresh"]:visible').first();
await refresh.scrollIntoViewIfNeeded({ timeout: 15_000 });
await refresh.click({ timeout: 15_000 });
await waitForRefreshCompletion(refresh, label, 15_000);
// Semantic activation, measured against the effect: with a gamepad injected, activating this way
// moves the reported count from 0 to 1, while a trusted pointer at the button's own centre leaves it
// at 0 - the click never reaches the command even though the rect is real. A locator click cannot
// work either (the node has pointer-events: none, so actionability never resolves). Which route
// reaches a given control is not something to assume from the others; it has to be observed.
await clickVisibleControl(page, gamepadRefresh);
await waitForRefreshCompletion(page, label, 15_000);
}

async function waitForRefreshCompletion(refresh, label, timeoutMs) {
async function waitForRefreshCompletion(page, label, timeoutMs) {
const deadline = Date.now() + timeoutMs;
let lastState = null;
let sawDisabled = false;
let consecutiveEnabledReadings = 0;

while (Date.now() < deadline) {
const found = await refresh.count() > 0;
const enabled = found && await refresh.isEnabled();
lastState = { found, enabled };
const state = await readControlState(page, gamepadRefresh);
lastState = { found: state.found, enabled: state.enabled };
if (lastState?.found && !lastState.enabled) {
sawDisabled = true;
consecutiveEnabledReadings = 0;
Expand Down Expand Up @@ -707,86 +662,11 @@ async function setInjectedGamepadButtons(page, pressedButtons) {

async function revealGamepadDiagnosticsSection(page) {
await waitForBodyText(page, diagnosticsPagePattern, "diagnostics settings page before gamepad reveal");

const headerTargets = {
labels: ["Gamepad input", "手柄输入", "Compatibility monitor", "兼容性监测"],
automationIds: ["Diagnostics.GamepadMonitorHeader"]
};

for (let attempt = 0; attempt < 20; attempt += 1) {
const state = await readControlState(page, gamepadStart);
if (state.found) {
return;
}

// The section hides behind an Expander, whose header is a ToggleButton; in the semantic DOM that
// maps to a node whose click the peer programs as Toggle, so semantic activation is the primary
// route. An earlier DOM-patching harness measured unreliable expansion from synthetic clicks and
// fell back to a real Playwright mouse click; that measurement predates the semantic activation
// contract, so the mouse click stays only as the fallback until CI confirms the primary route.
try {
await clickVisibleControl(page, headerTargets);
} catch {
const togglePoint = await page.evaluate(() => {
const normalize = value => (value ?? "").replace(/\s+/g, " ").trim().toLowerCase();
const start = document.querySelector('[xamlautomationid="Diagnostics.GamepadStart"]');
const expander =
start?.closest(".uno-expander")
?? start?.closest("[class*='Expander']")
?? start?.closest("details")
?? null;
const ownedToggle =
expander?.querySelector('[xamlautomationid="ExpanderToggleButton"], button, [role="button"], .uno-expanderheader, summary')
?? null;
if (ownedToggle) {
const rect = ownedToggle.getBoundingClientRect();
if (rect.width > 0 && rect.height > 0) {
return {
x: rect.left + rect.width / 2,
y: rect.top + rect.height / 2,
source: "owned-toggle"
};
}
}

const toggles = Array.from(
document.querySelectorAll('[xamlautomationid="ExpanderToggleButton"], button, [role="button"], summary'));
for (const toggle of toggles) {
const text = normalize(toggle.textContent);
if (text.includes("gamepad") || text.includes("手柄") || text.includes("compatibility monitor") || text.includes("兼容性监测")) {
const rect = toggle.getBoundingClientRect();
if (rect.width > 0 && rect.height > 0
&& rect.left >= -1
&& rect.top >= -1
&& rect.left <= innerWidth
&& rect.top <= innerHeight) {
return {
x: rect.left + rect.width / 2,
y: rect.top + rect.height / 2,
source: "text-toggle"
};
}
}
}

return null;
});

if (togglePoint) {
await page.mouse.click(togglePoint.x, togglePoint.y);
}
}

await page.waitForTimeout(500);
if ((await readControlState(page, gamepadStart)).found) {
return;
}

await scrollToVisibleControl(page, gamepadStart);
await page.mouse.wheel(0, 700);
await page.waitForTimeout(300);
}

const state = await readControlState(page, gamepadStart);
throw new Error(`Diagnostics gamepad section was not reachable in BrowserWasm. State=${JSON.stringify(state)}`);
await revealCollapsedSection(
page,
// The Expander header button, matched by the name a screen reader announces. Its automation id
// belongs to the header content inside it, which is a 0x0 group that cannot be toggled.
{ labels: ["Gamepad input", "手柄输入"], automationIds: [] },
gamepadStart,
"gamepad diagnostics section");
}
Loading
Loading