Skip to content

fix(tests): RecordingChatStore dispatch contract must not capture ambient context #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YoungSx merged 1 commit into from
Sep 7, 2026
Merged

fix(tests): RecordingChatStore dispatch contract must not capture ambient context #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/SalmonEgg.Presentation.Core.Tests/Chat/ChatViewModelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7564,22 +7564,24 @@ public RecordingChatStore(IState<ChatState> state, IWorkspaceWriter? workspaceWr

public async ValueTask Dispatch(ChatAction action)
{
// 临界区不捕获环境上下文：与真实 ChatStore.Dispatch 的契约一致，
// 闸的释放绝不依赖外部泵（fire-and-forget 分发也必须能自完成）。
_actions.Enqueue(action);
await _dispatchGate.WaitAsync();
await _dispatchGate.WaitAsync().ConfigureAwait(false);
try
{
var currentState = LatestState;
var updatedState = ChatReducer.Reduce(currentState, action);
LatestState = updatedState;
await State.Update(_ => updatedState, CancellationToken.None);
await State.Update(_ => updatedState, CancellationToken.None).ConfigureAwait(false);
if (updatedState.Generation > currentState.Generation)
{
_workspaceWriter?.Enqueue(updatedState, scheduleSave: true);
}

if (AfterDispatch is { } afterDispatch)
{
await afterDispatch(action);
await afterDispatch(action).ConfigureAwait(false);
}
}
finally
Expand All @@ -7591,7 +7593,7 @@ public async ValueTask Dispatch(ChatAction action)
public async ValueTask SetStateAsync(ChatState state)
{
LatestState = state;
await State.Update(_ => state, CancellationToken.None);
await State.Update(_ => state, CancellationToken.None).ConfigureAwait(false);
}

public ValueTask<ChatState> GetCurrentStateAsync()
Expand Down
Loading