π‘οΈ Sentinel: [HIGH] Fix execa environment variable leakage - #421
π‘οΈ Sentinel: [HIGH] Fix execa environment variable leakage#421google-labs-jules[bot] wants to merge 2 commits into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability:
execacalls withoutextendEnv: falseinherit the unsanitized parent environment, potentially exposing sensitive framework secrets (like API keys) to shell commands and subprocesses insrc/cli/authorization/non-interactive.tsandsrc/core/tools/capability/runner.ts.π― Impact: High impact as this allows spawned commands in various tools/capabilities to capture framework secrets in the environment.
π§ Fix: Ensure
execais called withextendEnv: falseand explicitly passsanitizeEnvironment(process.env)(or mergedprocess.env) to prevent leakages.β Verification: Tested using custom runner scripts and unit test suite verified (
bun run test:fullandshell-exec-env.test.ts). Fixed linting issues.PR created automatically by Jules for task 5464570045589228060 started by @YoungSx