🛡️ Sentinel: [HIGH] Fix framework secrets leakage via execa extendEnv - #427
🛡️ Sentinel: [HIGH] Fix framework secrets leakage via execa extendEnv#427google-labs-jules[bot] wants to merge 3 commits into
Conversation
- Use `sanitizeEnvironment` on the merged environment variables for `execa`. - Explicitly set `extendEnv: false` in `execa` options in `src/core/tools/capability/runner.ts` and `src/cli/authorization/non-interactive.ts`. - This ensures framework secrets like API keys do not leak to child processes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Use `sanitizeEnvironment` on the merged environment variables for `execa`. - Explicitly set `extendEnv: false` in `execa` options in `src/core/tools/capability/runner.ts` and `src/cli/authorization/non-interactive.ts`. - This ensures framework secrets like API keys do not leak to child processes. - Fix lint errors related to import ordering.
- Use `sanitizeEnvironment` on the merged environment variables for `execa`. - Explicitly set `extendEnv: false` in `execa` options in `src/core/tools/capability/runner.ts` and `src/cli/authorization/non-interactive.ts`. - This ensures framework secrets like API keys do not leak to child processes. - Fix oxfmt formatting issues.
🚨 Severity: HIGH
💡 Vulnerability:
execare-injects unsanitizedprocess.envby default whenextendEnvis true, causing framework secrets to leak into spawned processes.🎯 Impact: Framework secrets like API keys could be leaked to external tool processes or non-interactive authorization hooks.
🔧 Fix: Passed a sanitized environment object to
execaand explicitly setextendEnv: falseinsrc/core/tools/capability/runner.tsandsrc/cli/authorization/non-interactive.ts.✅ Verification: Ran test suite and type checks.
PR created automatically by Jules for task 3924860441003827814 started by @YoungSx