infra: ts-check tests (#1065)

salsita · Apr 4, 2024 · ec6c867 · ec6c867
1 parent db78a35
commit ec6c867
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 23 deletions.
diff --git a/test/sqlMigration.spec.ts b/test/sqlMigration.spec.ts
@@ -7,12 +7,15 @@ describe('sqlMigration', () => {
       const content = 'SELECT 1 FROM something';
       const { up, down } = getActions(content);
 
-      expect(up).toBeDefined();
-      expect(down).toBeFalsy();
+      expect(up).toBeTypeOf('function');
+      expect(down).toBe(false);
 
       const sql = vi.fn();
 
-      expect(up({ sql })).not.toBeDefined();
+      expect(
+        // @ts-expect-error: simplified for testing
+        up({ sql })
+      ).not.toBeDefined();
       expect(sql).toHaveBeenCalled();
       expect(sql).toHaveBeenLastCalledWith(content.trim());
     });
@@ -24,12 +27,15 @@ SELECT 1 FROM something
 `;
       const { up, down } = getActions(content);
 
-      expect(up).toBeDefined();
-      expect(down).toBeFalsy();
+      expect(up).toBeTypeOf('function');
+      expect(down).toBe(false);
 
       const sql = vi.fn();
 
-      expect(up({ sql })).not.toBeDefined();
+      expect(
+        // @ts-expect-error: simplified for testing
+        up({ sql })
+      ).not.toBeDefined();
       expect(sql).toHaveBeenCalled();
       expect(sql).toHaveBeenLastCalledWith(content);
     });
@@ -47,18 +53,24 @@ SELECT 2 FROM something
 
       const { up, down } = getActions(content);
 
-      expect(up).toBeDefined();
-      expect(down).toBeDefined();
+      expect(up).toBeTypeOf('function');
+      expect(down).toBeTypeOf('function');
 
       const upSql = vi.fn();
 
-      expect(up({ sql: upSql })).not.toBeDefined();
+      expect(
+        // @ts-expect-error: simplified for testing
+        up({ sql: upSql })
+      ).not.toBeDefined();
       expect(upSql).toHaveBeenCalled();
       expect(upSql).toHaveBeenLastCalledWith(upMigration);
 
       const downSql = vi.fn();
 
-      expect(down({ sql: downSql })).not.toBeDefined();
+      expect(
+        // @ts-expect-error: simplified for testing
+        down({ sql: downSql })
+      ).not.toBeDefined();
       expect(downSql).toHaveBeenCalled();
       expect(downSql).toHaveBeenLastCalledWith(downMigration);
     });
@@ -76,18 +88,24 @@ SELECT 2 FROM something
 
       const { up, down } = getActions(content);
 
-      expect(up).toBeDefined();
-      expect(down).toBeDefined();
+      expect(up).toBeTypeOf('function');
+      expect(down).toBeTypeOf('function');
 
       const upSql = vi.fn();
 
-      expect(up({ sql: upSql })).not.toBeDefined();
+      expect(
+        // @ts-expect-error: simplified for testing
+        up({ sql: upSql })
+      ).not.toBeDefined();
       expect(upSql).toHaveBeenCalled();
       expect(upSql).toHaveBeenLastCalledWith(upMigration);
 
       const downSql = vi.fn();
 
-      expect(down({ sql: downSql })).not.toBeDefined();
+      expect(
+        // @ts-expect-error: simplified for testing
+        down({ sql: downSql })
+      ).not.toBeDefined();
       expect(downSql).toHaveBeenCalled();
       expect(downSql).toHaveBeenLastCalledWith(downMigration);
     });
@@ -105,18 +123,24 @@ SELECT 2 FROM something
 
       const { up, down } = getActions(content);
 
-      expect(up).toBeDefined();
-      expect(down).toBeDefined();
+      expect(up).toBeTypeOf('function');
+      expect(down).toBeTypeOf('function');
 
       const upSql = vi.fn();
 
-      expect(up({ sql: upSql })).not.toBeDefined();
+      expect(
+        // @ts-expect-error: simplified for testing
+        up({ sql: upSql })
+      ).not.toBeDefined();
       expect(upSql).toHaveBeenCalled();
       expect(upSql).toHaveBeenLastCalledWith(upMigration);
 
       const downSql = vi.fn();
 
-      expect(down({ sql: downSql })).not.toBeDefined();
+      expect(
+        // @ts-expect-error: simplified for testing
+        down({ sql: downSql })
+      ).not.toBeDefined();
       expect(downSql).toHaveBeenCalled();
       expect(downSql).toHaveBeenLastCalledWith(downMigration);
     });

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,9 +1,9 @@
 {
   "compilerOptions": {
-    "target": "ES2019",
+    "target": "ES2020",
     "module": "CommonJS",
     "moduleResolution": "Node",
-    "lib": ["ES2019", "DOM"],
+    "lib": ["ES2020", "DOM"],
     "noEmit": true,
     "esModuleInterop": true,
     "sourceMap": false,
@@ -14,5 +14,5 @@
     "noImplicitOverride": true,
     "skipLibCheck": true
   },
-  "exclude": ["node_modules", "templates", "test", "dist", "bin", "migrations"]
+  "exclude": ["node_modules", "templates", "dist", "bin", "migrations"]
 }
diff --git a/tsconfig.lint.json b/tsconfig.lint.json
@@ -1,11 +1,11 @@
 {
   "compilerOptions": {
-    "target": "ES2019",
+    "target": "ES2020",
     "moduleResolution": "Node",
     "module": "CommonJS",
     "strict": true,
     "noEmit": true,
-    "lib": ["ES2019"],
+    "lib": ["ES2020"],
     "esModuleInterop": true,
     "forceConsistentCasingInFileNames": true,
     "noImplicitAny": true,