chore(sdds-sbcom): use theme tokens in component configs#2639
Draft
chore(sdds-sbcom): use theme tokens in component configs#2639
Conversation
Contributor
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-2639/ |
Contributor
|
Documentation preview deployed! website: https://plasma.sberdevices.ru/pr/pr-2639/ |
Yeti-or
commented
Mar 27, 2026
Contributor
Author
There was a problem hiding this comment.
Видимо h5 / h6 надо убирать ? сс @Yakutoc
| h3, | ||
| h4, | ||
| h5, | ||
| h6, |
Contributor
Author
There was a problem hiding this comment.
нет таких токенов - h5 / h6
| @@ -197,12 +223,12 @@ export const config = { | |||
| ${tabsTokens.itemMarginLeft}: 1.5rem; | |||
| ${tabsTokens.itemContentGap}: 0.625rem; | |||
|
|
|||
| ${tabsTokens.fontFamily}: var(--plasma-typo-h6-font-family); | |||
Contributor
Author
There was a problem hiding this comment.
Вот тут undefined, @neretin-trike это к вопросу что я пытался решить. Мы меняем sdds-com темы, и у нас потенциально компоненты разваливаются
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## SDDS-SBCOMAll
- Замена использования css переменных на дизайн-токены из темы sdds-sbcomWhat/why changed
Рефакторинг конфигов всех компонентов внутри библиотеки sdds-sbcom.
Используем токены из
sdds-themes/tokens/sdds_sbcomвместо css переменныхПрежде чем перевести в статус "requested a review" убедитесь