-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SQS support #34
Conversation
Wow, thanks for the large change. This is awesome! |
No problem! Let me know if you want me to change something, or feel free to do it yourself. |
I'll check if SQS and SNS clients work... |
Hey so it still doesn't work for SNS and SQS. What does it take for it to work, is it on AWS' side? Sorry about the hassle 😢 |
We will have to check that it is sending the right protocol. Does the JSON api as defined in the types match what the api expects? No bother! Sorry I haven't been able to help, have been busy! |
Spent some hours last night diving into this. Got good news:
I was thinking about repurposing this PR so it runs tests in CI with LocalStack, including SQS. Then, add support for SNS with a custom SNS handler. |
Awesome! That's interesting about SNS, what needs to be done to adapt? Should we re open the PR? |
SNS seems to work the same way as S3 does:
|
Ah, got it. So only SQS received the JSON API upgrade. Here's hoping 🤞 they do this across the board. |
SNS api is probably a lot simpler than S3? S3 had complicated surface area and streaming protocol on top of that. |
I bet! I'll have a look on SNS soon. |
Wanna merge SQS? We can release incrementally without much worry. |
Don't think I've ever seen a million line PR. Is that because we are checking in AWS models? Maybe we should not check that in? |
Yup, done 👍🏻
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to identify changes because of formatting updates. But I'm also glad you updated the repo's config so thoroughly lol.
Important changes to
The rest is just formatting changes. |
bench:synth