Skip to content

Refactor dividing lines into a class "divider" that adds a border-top… #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor dividing lines into a class "divider" that adds a border-top… #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ <h2 id="title">
<ul>
{% for link in site.plainwhite.navigation %}
<li>
<a href="{{ link.url }}">{{ link.title }}</a>
<a href="{{ link.url }}" {% unless forloop.first %}class="divider"{% endunless %}>{{ link.title }}</a>
</li>
{% endfor %}
</ul>
Expand All @@ -151,7 +151,7 @@ <h2 id="title">
<section class="content">
{{ content }}
</section>
<footer class="{{condensed_class}}">
<footer class="{{condensed_class}} divider">
{{ footer }}
</footer>
</main>
Expand Down
2 changes: 2 additions & 0 deletions _layouts/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ <h1 id="posts-label">posts</h1>
{% endif %}
</li>

<hr class="post-list divider" />

{%- for post in site.posts -%}
<li>
{%- assign date_format = site.plainwhite.date_format | default: "%b %-d, %Y" -%}
Expand Down
5 changes: 1 addition & 4 deletions _sass/dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
$dark_link_color: #4da3ff;
background-color: #171717;
color: $dark_text_color;
border-color: #e6e6e6;
border-color: #272727;

.about{
img.light {
Expand All @@ -24,7 +24,6 @@

#posts-label {
color: $dark_text_color;
border-bottom: 1px solid #272727;
}

@import 'ext/solarized-dark';
Expand Down Expand Up @@ -61,8 +60,6 @@
}

.posts-labelgroup {

border-bottom: 1px solid #333;
.search-results {
background-color: #333;

Expand Down
21 changes: 11 additions & 10 deletions _sass/plain.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ $leftWidth: 220px;
*:before,
*:after {
box-sizing: border-box;
border-color: #ececec;
}

body {
Expand Down Expand Up @@ -156,19 +157,12 @@ main {
padding: 0;
margin-top: 0;

li:last-child {
a {
border-bottom: 0;
}
}

a {
display: block;
font-family: 'Merriweather';
text-align: center;
padding: 1rem 0;
text-decoration: none;
border-bottom: 1px solid #ececec;

@media screen and (max-width: $mobileW) {
padding: 2rem 0;
Expand Down Expand Up @@ -268,10 +262,13 @@ main {
}
}
.posts-labelgroup {
margin: 0 0 0.67em 0;
margin: 0;
display: flex;
align-items: baseline;
border-bottom: 1px solid #eee;
}

.post-list {
padding: 0.67em 0 0 0;
}

#posts-label {
Expand Down Expand Up @@ -331,6 +328,10 @@ footer {
@media screen and (max-width: $smallMobileW){
margin: 0 20px;
}
border-top: 1px solid #eee;
}
}

.divider {
border-width: 1px 0 0 0;
border-top-style: solid;
}