Add DoInAttemptWithDelay and DoInAttempt functions#450
Open
marktiro wants to merge 1 commit intosamber:masterfrom
Open
Add DoInAttemptWithDelay and DoInAttempt functions#450marktiro wants to merge 1 commit intosamber:masterfrom
marktiro wants to merge 1 commit intosamber:masterfrom
Conversation
Owner
|
Why not just implement Attempt0, Attempt1, Attempt2 ... AttemptX ? |
Author
it's been a while since your reply 😄 Actually, you are completely right, I will rewrite the functions to ones with numbers at the end 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Attemptlike functions are awesome and help a lot with operations prone to fail, i.e. networking stuff.Nevertheless, only procedure implementation is available in the library. So, it forced me to use constructions like the following:
I ended up doing this stuff so often, so I decided to contribute if you do not mind :)