refactor: extract codebreaking into standalone module - #102
Merged
Merged
Conversation
…results Move codebreaking logic out of utils/ into its own top-level src/codebreaking/ module, split into focused files (enigma-int, crib-analysis, crib-search), extract named functions from large blocks, DRY up repeated patterns, and add result pagination to the Break Cipher UI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/utils/codebreaking.tsxtosrc/codebreaking/as its own top-level module, split into three focused files:enigma-int.tsx(integer-path primitives),crib-analysis.tsx(crib positions, menu graphs, BFS propagation), andcrib-search.tsx(search orchestrator)cribSearchAsync(buildSearchContext,computeAllRotorPositions,precomputeScramblerLookups,testCribPosition,collectResult) and DRY up repeated MOD26 rotor pass pattern intorotorPassForward/rotorPassInverseTest plan
🤖 Generated with Claude Code