fix: enable background and foreground cipher search processing - #122
Merged
Merged
Conversation
…round processing setTimeout chains scheduled from the main JS context get suspended when the app is backgrounded on Android. Moving cribSearchAsync inside the BackgroundService task callback ensures the search continues running when the app is not in focus. Also simplified isCancelled to only check the cancelled flag rather than coupling it to BackgroundService.isRunning(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setTimeoutchains scheduled from the main JS context get suspended by Android when the app loses focus. Only code running inside theBackgroundService.start()task callback stays alive.cribSearchAsyncto run inside the background task callback so the search continues reliably in the backgroundisCancelledfromBackgroundService.isRunning()to prevent false cancellationsTest plan
npm test) — 132 tests pass🤖 Generated with Claude Code