Skip to content

Fix vNext memory commit schema aliases#222

Merged
samrusani merged 1 commit into
mainfrom
fix/vnext-memory-commit-schema-aliases
Jun 2, 2026
Merged

Fix vNext memory commit schema aliases#222
samrusani merged 1 commit into
mainfrom
fix/vnext-memory-commit-schema-aliases

Conversation

@samrusani
Copy link
Copy Markdown
Owner

@samrusani samrusani commented Jun 2, 2026

Summary

  • Normalize common agent-supplied quote memory labels to schema-backed vNext values before Postgres writes.
  • Publish canonical memory_type/domain/sensitivity enums through the MCP tool schema and convert Postgres check violations into controlled MCP tool errors.
  • Update agent docs so quote saves use memory_type=semantic and domain=learning instead of invented labels.

Upgrade Overview

Protected Areas

  • continuity APIs

Compatibility Impact

MCP callers that send canonical vNext memory labels continue to behave the same. Common quote aliases such as memory_type=quote and domain=quotes now normalize to schema-backed values instead of surfacing a Postgres CheckViolation.

Migration / Rollout

No database migration is required. Roll out by deploying the API/MCP code and restarting any long-running alice-core MCP process so agents load the updated schema and validation path.

Operator Action

If an agent previously hit repeated alice_vnext_commit_memory CheckViolation errors, restart the agent or MCP session after deploy and retry with canonical values. For quote saves, use memory_type=semantic and domain=learning.

Validation

Validated locally with the full Python unit suite, the agentic-memory-commit smoke, API health, and whitespace checks.

Rollback

Revert this PR if the MCP enum normalization causes unexpected caller behavior. Existing database rows are unchanged because this patch does not alter persisted schema or run migrations.

Validation

  • ./.venv/bin/pytest tests/unit -q
  • ./.venv/bin/alicebot vnext smoke agentic-memory-commit
  • curl -sS http://127.0.0.1:8000/healthz
  • git diff --cached --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@samrusani samrusani merged commit 229fae7 into main Jun 2, 2026
5 of 6 checks passed
@samrusani samrusani deleted the fix/vnext-memory-commit-schema-aliases branch June 2, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant