fix: give the correct connection string to customer micro service. - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the dev deployment gap that was causing
customerservice-devto fail activation in Azure Container Apps.CustomerServicewas starting with its image-default local SQL connection string (localhost,1433) because the dev CD workflow did not configureConnectionStrings__DefaultConnectionforcustomerservice-dev. Since the service opens a database connection during startup, the container crashed before ingress could become healthy.This change updates the dev workflow so
customerservice-devreceives its Azure SQL connection string and required internal service endpoints during deployment, then adds direct smoke tests to catch future regressions.Changes Made
Configure CustomerService DB connection and service endpointsstep to.github/workflows/cd-dev.ymlConnectionStrings__DefaultConnectionforcustomerservice-devfromcustomer-db-connServiceEndpoints__ProductService=http://productservice-devServiceEndpoints__OrderService=http://orderservice-devResolve CustomerService URLstep in the dev workflow/health/api/commerce/products?pageNumber=1&pageSize=1How to Test
CD Dev — Migrate, Build & Push all services, Deploy to Azureworkflow.Configure CustomerService DB connection and service endpointsstep succeeds.Resolve CustomerService URLstep succeeds.Smoke tests — CustomerService direct endpointsstep returns200for both endpoints.customerservice-devno longer starts with the fallbacklocalhost,1433SQL configuration and the revision becomes healthy after deployment.Screenshots / Logs (if applicable)
An error occurred using the connection to database 'insighterp_db' on server 'localhost,1433'A network-related or instance-specific error occurred while establishing a connection to SQL ServerRelated Issues / Tickets
customerservice-devactivation failure caused by missing dev deployment configuration forCustomerService