Workspace flow + TestSpec generation #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation should now work
… checking). begin to look for `start` argument of pathspec
…ate it. fixed up garbage collecting
mdmosby
approved these changes
Nov 20, 2025
Collaborator
mdmosby
left a comment
mdmosby
left a comment
There was a problem hiding this comment.
Minor things that can wait
|
|
||
| @canary.hookimpl(wrapper=True) | ||
| def canary_cdash_artifacts(case: canary.TestCase) -> Generator[None, None, list[dict[str, str]]]: | ||
| """Default implementation: return the test case's keywords""" |
Collaborator
There was a problem hiding this comment.
Suggested change
| """Default implementation: return the test case's keywords""" | |
| """Default implementation: return the test case's artifact specifications""" |
Should canary.TestCase use this Schema to validate the artifacts specification?
| rparameters: dict[str, int] | ||
| assets: list["Asset"] | ||
| baseline: list[dict] | ||
| artifacts: list[dict[str, str]] |
Collaborator
There was a problem hiding this comment.
Should we validate the artifacts Schema as part of post_init?
Comment on lines
+177
to
+182
| artifacts = list(case.spec.artifacts) or [] | ||
| result = yield | ||
| artifacts.extend([_ for _ in result if _]) | ||
| for i, artifact in enumerate(artifacts): | ||
| artifacts[i] = schema.validate(artifact) | ||
| return artifacts |
Collaborator
There was a problem hiding this comment.
What is the expected behavior if artifacts include elements with duplicate file values and conflicting when values?
`Path.hardlink_to` requires that `src` and `dst` are on the same **filesystem** which is a more-stringent requirement than we've previously had. Furthermore, `hardlink_to` does not follow copy symantics in that modifying the hardlinked file _also modifies the source_! Which may be unexpected behavior when one specifies `copy`.
1. Generator plugins must now implement canary_collect_file_patterns that returns a list of glob patterns that the generator recognizes 2. During discovery, we walk the tree and collect all files matching patterns from above 3. After collection, we call another new plugin canary_collect_filter_files. This plugin can filter out files from the list collected. This is useful for the ctest plugin to remove all but the first CTestTestfile in a tree 4. After filtering, create test case generators in parallel. Additionally, store all generator meta data in a single file. With the above changes, time to collect generators for a large test suite went from 25-30 seconds to less than 1 second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #66 and includes all its details. Additionally, it includes a major change to the generation of test cases as described in spec-case.md