Skip to content

Conversation

albuwab
Copy link
Contributor

@albuwab albuwab commented Feb 13, 2024

The vrouter will fail to implement rules in the router image that is booted if the "id" key is not present in the config. This must be included. The app Golang code should be updated with better errors.

The vrouter will fail to implement rules in the router image that is booted if the "id" key is not present in the config. This must be included. The app Golang code should be updated with better errors.
Copy link
Collaborator

@GhostofGoes GhostofGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, otherwise LGTM, and thanks for the contribution!

docs/apps.md Outdated
@@ -137,6 +139,7 @@ spec:
rules.

* `rules`: list of rules to apply to traffic.
* `id`: integer to identify the order of the fules in the set.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo

@GhostofGoes GhostofGoes merged commit f037eee into sandialabs:main Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants