add labware updated_at value and return the latest one#5780
Open
wendyyang wants to merge 8 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5780 +/- ##
===========================================
+ Coverage 84.06% 87.31% +3.24%
===========================================
Files 1422 1479 +57
Lines 32730 33594 +864
Branches 3502 3557 +55
===========================================
+ Hits 27513 29331 +1818
+ Misses 5195 4242 -953
+ Partials 22 21 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wendyyang
requested review from
KatyTaylor,
StephenHulme,
andrewsparkes and
yoldas
Contributor
StephenHulme
left a comment
StephenHulme
left a comment
There was a problem hiding this comment.
Some comments and suggestions : )
| end | ||
|
|
||
| nil | ||
| end |
Contributor
There was a problem hiding this comment.
Would it be possible to reduce the complexity of this function (possibly by pulling out some private methods)?
It's difficult to understand exactly what the new code does.
StephenHulme
approved these changes
May 18, 2026
Contributor
StephenHulme
left a comment
StephenHulme
left a comment
There was a problem hiding this comment.
Thanks for the changes
yoldas
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
add labware updated_at in API return and return the latest location
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version