Submission parameters fix#5814
Merged
Merged
Conversation
StephenHulme
approved these changes
May 28, 2026
Contributor
StephenHulme
left a comment
There was a problem hiding this comment.
Looks like a good fix - assuming this is the right place - don't know how to check though...
Contributor
|
Can replicate it locally and confirmed that this fix works as intended 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5814 +/- ##
==========================================
+ Coverage 87.33% 87.35% +0.02%
==========================================
Files 1480 1480
Lines 33637 33637
Branches 3569 3569
==========================================
+ Hits 29376 29383 +7
+ Misses 4240 4233 -7
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This shows allowing FieldInfo is enough for submission_templates select trim(substring_index(submission_parameters, '!ruby/object', -1))
from sequencescape_production.submission_templates
where submission_parameters LIKE '%!ruby/object%'; |
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hot-fix to address [#SR-64875] - Assigned to Team - Issues Creating Cherrypicks
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version