Skip to content

Submission parameters fix#5814

Merged
BenTopping merged 2 commits into
masterfrom
submission-parameters-fix
May 28, 2026
Merged

Submission parameters fix#5814
BenTopping merged 2 commits into
masterfrom
submission-parameters-fix

Conversation

@BenTopping
Copy link
Copy Markdown
Contributor

@BenTopping BenTopping commented May 28, 2026

Hot-fix to address [#SR-64875] - Assigned to Team - Issues Creating Cherrypicks

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@BenTopping BenTopping changed the base branch from develop to master May 28, 2026 13:55
Copy link
Copy Markdown
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix - assuming this is the right place - don't know how to check though...

@StephenHulme
Copy link
Copy Markdown
Contributor

Can replicate it locally and confirmed that this fix works as intended 🚀

@BenTopping BenTopping marked this pull request as ready for review May 28, 2026 14:10
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.35%. Comparing base (61fc132) to head (80cc1d2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5814      +/-   ##
==========================================
+ Coverage   87.33%   87.35%   +0.02%     
==========================================
  Files        1480     1480              
  Lines       33637    33637              
  Branches     3569     3569              
==========================================
+ Hits        29376    29383       +7     
+ Misses       4240     4233       -7     
  Partials       21       21              
Flag Coverage Δ
javascript 76.31% <ø> (ø)
ruby 87.35% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BenTopping BenTopping merged commit 5c6832f into master May 28, 2026
30 of 32 checks passed
@BenTopping BenTopping deleted the submission-parameters-fix branch May 28, 2026 14:24
@yoldas
Copy link
Copy Markdown
Member

yoldas commented May 28, 2026

This shows allowing FieldInfo is enough for submission_templates

select trim(substring_index(submission_parameters, '!ruby/object', -1))
from sequencescape_production.submission_templates
where submission_parameters LIKE '%!ruby/object%';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants