refactor(core): return named function for readability

sanity-io · Sep 16, 2024 · d94115a · d94115a
1 parent 47cd411
commit d94115a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 17 deletions.
diff --git a/packages/sanity/src/core/form/store/conditional-property/createCallbackResolver.ts b/packages/sanity/src/core/form/store/conditional-property/createCallbackResolver.ts
@@ -151,12 +151,12 @@ export function createCallbackResolver<TProperty extends 'hidden' | 'readOnly'>(
   const stableTrue = {value: true}
   let last: {serializedHash: string; result: StateTree<boolean> | undefined} | null = null
 
-  return ({
+  function callbackResult({
     currentUser,
     documentValue,
     schemaType,
     ...options
-  }: ResolveRootCallbackStateOptions<TProperty>) => {
+  }: ResolveRootCallbackStateOptions<TProperty>) {
     const hash = {
       currentUser: getId(currentUser),
       schemaType: getId(schemaType),
@@ -192,4 +192,6 @@ export function createCallbackResolver<TProperty extends 'hidden' | 'readOnly'>(
 
     return result
   }
+
+  return callbackResult
 }
diff --git a/packages/sanity/src/core/form/store/utils/createMemoizer.ts b/packages/sanity/src/core/form/store/utils/createMemoizer.ts
@@ -22,30 +22,21 @@ export function createMemoizer<TFunction extends (...args: never[]) => unknown>(
 }: MemoizerOptions<TFunction>): FunctionDecorator<TFunction> {
   const cache = new Map<string, {serializedHash: string; result: ReturnType<TFunction>}>()
 
-  return (fn) => {
-    const memoizedFn = ((...args: Parameters<TFunction>) => {
+  function memoizer(fn: TFunction): TFunction {
+    function memoizedFn(...args: Parameters<TFunction>) {
       const path = toString(getPath(...args))
       const hashed = hashInput(...args)
       const serializedHash = JSON.stringify(hashed)
       const cached = cache.get(path)
       if (serializedHash === cached?.serializedHash) return cached.result
 
-      // if (cached) {
-      //   console.log({
-      //     name: fn.name,
-      //     path,
-      //     // reason: objectDiff(JSON.parse(cached.serializedHash), hashed).join(', '),
-      //     prev: JSON.parse(cached.serializedHash),
-      //     next: hashed,
-      //   })
-      // }
-
       const result = fn(...args) as ReturnType<TFunction>
       cache.set(path, {serializedHash, result})
-
       return result
-    }) as TFunction
+    }
 
-    return decorator(memoizedFn)
+    return decorator(memoizedFn as TFunction)
   }
+
+  return memoizer
 }