perf(core): memoize prepareFormState
#7498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
bjoerge
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Amazing work and really impressive numbers @ricokahler – left a few comments, mostly minor stuff.
packages/sanity/src/core/form/store/conditional-property/createCallbackResolver.ts
Outdated
Show resolved
Hide resolved
ricokahler
force-pushed
the
perf/memoize-prepare-form-state
branch
from
f26a12f
to
47cd411
Compare
ricokahler
force-pushed
the
perf/memoize-prepare-form-state
branch
from
8c7b898
to
199df15
Compare
ricokahler
force-pushed
the
perf/memoize-prepare-form-state
branch
from
199df15
to
35c17a7
Compare
|
Component Testing Report Updated Sep 17, 2024 6:29 PM (UTC) ✅ All Tests Passed -- expand for details
|
cngonzalez
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces memoization to the
prepareFormStatefunction to significantly improve performance, especially for complex documents with multiple large objects in arrays.Key changes:
prepareFormStateand its sub-functions for improved performance for complex documents, with up to 10x improvements in some caseshiddenandreadOnly. TheirStateTrees are calculated outside ofprepareFormStateto remove the dependency of thedocumentto the inputs ofprepareFormState.This addresses performance issues with form state computation, particularly for large and complex documents.
Note: Dependes on #7407
What to review
prepareFormStateTesting
Automated tests are not yet complete. Manual testing has been performed:
Before:
After:
TODO: Complete automated tests
Notes for release
This change introduces significant performance improvements for form state computation in Sanity, especially for complex documents:
Limitations:
hiddenandreadOnlystates still adds significant computation time, especially for very large documentsNote: This is a significant performance enhancement that will benefit most users, especially those working with complex document structures.